[OT-86][REFACTOR]: ERD 수정에 따른 백오피스 시리즈 관리 페이지 API 변경#52
Merged
Conversation
…o OT-86-refactor/backoffice-series
📝 WalkthroughWalkthrough백오피스 시리즈 관리 API를 ERD 변경에 맞춰 리팩토링합니다. Series 중심에서 Media 중심 구조로 전환하며, API 파라미터를 seriesId에서 mediaId로 변경하고, 매퍼 및 서비스 로직과 저장소를 Media/MediaTag 기반으로 업데이트합니다. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
modules/domain/src/main/java/com/ott/domain/series/repository/SeriesRepository.java (1)
15-22: 주석으로 남은 폐기 쿼리 코드는 정리해도 됩니다.현재 비활성화된 코드가 유지보수에 불필요한 잡음을 줄 수 있습니다.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@modules/domain/src/main/java/com/ott/domain/series/repository/SeriesRepository.java` around lines 15 - 22, Remove the commented-out deprecated query block in SeriesRepository: delete the entire commented `@Query` and the searchLatest method signature (the commented lines referencing searchLatest, `@Query`, `@Param`("keyword"), `@Param`("status"), and Pageable) to eliminate dead code noise and keep the repository clean.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@modules/domain/src/main/java/com/ott/domain/series/repository/SeriesRepository.java`:
- Around line 15-22: Remove the commented-out deprecated query block in
SeriesRepository: delete the entire commented `@Query` and the searchLatest method
signature (the commented lines referencing searchLatest, `@Query`,
`@Param`("keyword"), `@Param`("status"), and Pageable) to eliminate dead code noise
and keep the repository clean.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📷 스크린샷
[시리즈 목록 조회]
[시리즈 상세 조회]
☑️ 체크 리스트
#️⃣ 연관된 이슈
closes #46
💬 리뷰 요구사항
시리즈 관리 페이지 API 수정했습니다.
[공통]
목록 조회, 상세 조회 모두 mediaId를 반환합니다.
#31
위 PR에서의 수정 사항 반영입니다.
Summary by CodeRabbit
릴리스 노트
seriesId에서mediaId로 변경되었습니다.seriesId에서mediaId로 변경되었습니다.